feat(cloud_sql): Add cloud sql psa+psc connectivity samples #808
Conversation
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
loeng2023
force-pushed
the
bug-383556956
branch
from
22c3eda to
173863d
Compare
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
Region tags must be globally unique, there are a lot of files here that are duplicating region tags from other files.
Let's remove the duplicate ones, that way the code samples in our docs will have one source of truth 😄
loeng2023
force-pushed
the
bug-383556956
branch
from
2c5e855 to
be61fa4
Compare
|
/gcbrun |
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
I think we still need to be more careful with the region tags. We do not need to add region tags around pieces of code that are identical from one MySQL file to another MySQL file and which already has region tags. This PR should focus on adding region tags solely around code pieces that are new logic and contain PSA + PSC functionality.
Suggestions should be applied to Postgres and SQL Server as well.
This will make the code much more maintainable in the future and prevent having three different region tags around identical code blocks, leading to one source of truth for docs.
|
/gcbrun |
|
/gcbrun |
…m-google-modules#808) * feat(cloud_sql): Add cloud sql psa+psc connectivity samples * fix region tags * Fix license year * remove unnecessary region tags * add short description at beginning * minor change * avoid use auto-subnet ip as static ip * fix lint --------- Co-authored-by: Jack Wotherspoon <[email protected]>
3 participants
Description
Fixes 383556956
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review